Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24.3 Universal config for crossing out failed tests #514

Open
wants to merge 8 commits into
base: 24.3.5-snapshot_runners
Choose a base branch
from
Open

24.3 Universal config for crossing out failed tests #514

wants to merge 8 commits into from

Conversation

strtgbb
Copy link
Collaborator

@strtgbb strtgbb commented Oct 30, 2024 •
edited
Loading

A universal approach to crossing out failed tests

This expands and replaces the similar system in #472

Error message matching is only supported for integration tests.

@altinity-robot
Copy link
Collaborator

altinity-robot commented Oct 30, 2024 •
edited
Loading

This is an automated comment for commit 95eb88c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Ready for releaseThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success

@strtgbb strtgbb force-pushed the universal_override_broken_tests branch from 43929f1 to 12fc318 Compare October 31, 2024 13:13
@strtgbb strtgbb requested a review from MyroTk November 6, 2024 13:31
@strtgbb strtgbb force-pushed the universal_override_broken_tests branch from 667e589 to d720a45 Compare November 8, 2024 18:13
@Enmk Enmk changed the title Universal config for crossing out failed tests 24.3 Universal config for crossing out failed tests Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyroTk MyroTk Awaiting requested review from MyroTk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strtgbb @altinity-robot